New Release: Vault Phase 1 (real vault)

Sure, I agree they should be consistent. I was just pointing out there was a good reason they weren’t. We have a finite amount of resources and didn’t have the time to refactor the safe_auth code to bring the 2 interfaces in line. As @joshuef says, perhaps we may even have safe_auth merged in safe at some point.

8 Likes

@mav I just need to check the self update crate is compatible with zips, but otherwise should be able to change to zip rather than tar for the next release.

@draw Good point - can also add a strip into the build process.

6 Likes

Personally I don’t mind a couple of extra megabytes at this point. And maybe that what is being stripped can be helpful in case of a bug.

4 Likes

Sounds like a reasonable approach. People tend to copy paste cmd snippets in order to learn and I think in that sense it’s better to be over-explicit (verbose) in regard of the syntax than too implicit. Same goes for the --from/-to options etc. Might reduce the learning curve drastically. :slight_smile:

4 Likes

Amazing progress. Can’t wait for Fleming

6 Likes

It was not that easy (advanced Bash programming) and took some time, but I’ve got Bash auto-completion working on Linux Mint 19.1. I guess it will also work on other Linux distributions.
For the ones interested, do the following (with <tab> = pressing ‘tab’-keyboard key):

$ safe cat safe://acompl/safe_completion.sh > ~/.safe_completion.sh
$ source ~/.safe_completion.sh
$ safe <tab><tab>
$ safe ca<tab> s<tab>dweb/<tab>
$ ...

If you want the safe tab completion persistent: add

source ~/.safe_completion.sh

to e.g. ~/.bashrc

You can get .safe_completion.sh also from Github.

Of course you can change or improve this if necessary.

20 Likes

After 2 hours of cursing at the computer screen last night, I finally realized I had downloaded the dev version of auth and wasn’t connecting to the shared vault because of that.

Now?! I sent bochaco 2 test-safecoin. Feels good. Cli is intuitive and pretty easy to use.
Only comment is for transfer. Everything from emails to christmans gifts (at least here in the US) are from then to. So having the “to” first in the transfer seems weird.

17 Likes

Well that is rad. Will be great if we’re able to ship this w/ the bins.

13 Likes

Ha ha - we’ve all been there! I notice the dev versions of the latest binaries are now in a separate page on Github which is a good move :+1:

9 Likes

This is really great! I definitely want to get this distributed with the releases somehow. Will discuss with the team.

12 Likes

That’s really cool @draw! Just FYI and if you wanna use the following for posting more info also, I created this some time ago based on your earlier suggestion about autocomplete: https://github.com/maidsafe/safe-cli/issues/73. We should aim at having it within the Rust binary itself.

6 Likes
  • Yes the auto-completion could be in the Rust binary itself, like my earlier suggestion, or e.g. a ‘safe cat’ output option that is easier to process for an autocomplete script.
  • Did you also have plans for an interface ‘shell’ version of the safe cmdline tool? Maybe too much work for the added benefit atm?
  • Another suggestion: maybe overkill but skim: a Fuzzy Finder in Rust could be useful. I encountered that in the following small app of @pierrechevalier83: find_unicode. That could for example be used to interactively filter a list of paths.
  • For Bash (autocompletion) under Windows:

–>I had a quick look. The (safe) Windows binaries don’t work (only ELF binary format I think). Also the Linux version didn’t work. safe_auth gives Corerror::RequestTimeout on src/libcore/result.rs:999:5. Maybe Cygwin or wait until WSL2 begin next year? List of programs that work (partly) with WSL.

4 Likes

We imagined it also, see section “CLI Interactive Shell” in SAFE CLI - High Level Design Document , regardless of the features it may contain, it’ll basically allow us to have some state across commands. In recent discussions it was also brought up the idea that it will be the way to merge safe_auth into safe_cli app since you need to be able to allow/deny auth reqs, etc.

4 Likes

@mav @draw

PR here addressing some of your feedback:

  • Include the bash auto completion file with some instructions on the release description for how to use it (thanks again for that!)
  • Run strip on the release builds
  • Distribute zips rather than tars

The issue with --help on vault has been addressed and @jonhaggblad also added a --verbose switch to make the output on vault a bit clearer.

I know @bochaco has also been looking at possibly getting some fixes in with safe too.

We’re hoping to release these patches sometime this week.

16 Likes

When you mentioned Bash autocompletion on Windows I was curious if that would work in Git Bash. You can run a Windows binary in that, but for autocompletion you actually need to have a bash-completion package installed (even on Linux I think). It may possibly work with an MSYS2 installation, which also runs Windows binaries. It has a package manager so you can install additional stuff, but probably too much hassle for most people, I would imagine.

I think Windows users may sadly be out of luck on this one until Gabriel can implement it in Rust :wink:

1 Like
  • I don’t have that much experience with Bash on Windows.
    If it is too difficult to get the binaries to work on WSL, better to wait on WSL 2 I guess. Something else then WSL is indeed probably too much of a hassle.
  • I assume that “CLI Interactive Shell” doesn’t need Bash, but you still need Bash in my earlier suggestion where autocomplete is implemented in Rust:

complete -C _cargo_completion cargo

1 Like

Please continue to distribute tar or tar.gz files.

4 Likes

No problem - can also add in tar.gz assets.

4 Likes

Ooookkay. After some hearty digging around the undergrowth of electron / neon and webpack, we’ve gotten updated browser POCs up for linux and mac.

You can find those here: https://github.com/maidsafe/safe_browser/releases/tag/CLI-POC-2

15 Likes

For the curious ones: https://github.com/maidsafe/safe-cli/pull/232

11 Likes